Skip to content

Conversation

kylecarbs
Copy link
Member

No description provided.

@kylecarbs kylecarbs requested a review from hugodutka October 17, 2025 19:36
@kylecarbs kylecarbs self-assigned this Oct 17, 2025
Copy link
Collaborator

@hugodutka hugodutka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should require a blink deploy --config $path_to_config_json flag in CI mode. The .blink directory is in .gitignore by default and it's a hassle to add just .blink/config.json to version control. It'd also allow people to deploy to another agent for staging.

Comment on lines 94 to 96
throw new Error(
"Multiple organizations found. In CI mode, you must first deploy locally to select an organization, " +
"or set the organization in .blink/config.json"
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new Error(
"Multiple organizations found. In CI mode, you must first deploy locally to select an organization, " +
"or set the organization in .blink/config.json"
);
throw new Error(
"Multiple organizations found. To use CI mode, please deploy in interactive mode first to select an organization and generate .blink/config.json"
);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylecarbs any chance to merge that one in?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a little bit of backend work to make this usable. Right now our web UI doesn't offer a way to generate/manage API keys. While technically you could copy the generated credentials after you run blink login into CI variables, they only last 30 days and are irrevocable.

@hugodutka hugodutka force-pushed the ciable branch 2 times, most recently from 272acc5 to 175fed6 Compare October 22, 2025 14:23
@hugodutka hugodutka merged commit 66f1561 into main Oct 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants